gh-152260: Fix test_scr_dump() on macOS#152340
Merged
serhiy-storchaka merged 1 commit intoJun 26, 2026
Merged
Conversation
The dump format embeds raw pointers on some platforms, so two dumps of the same screen are not always byte-identical. Only compare dump files when the format proves deterministic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added
skip news
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_scr_dump()comparedscr_dump()output files for byte equality, but the dump format embeds raw pointers on some platforms (such as the ncurses shipped with macOS), so two dumps of the same screen are not byte-identical. This madetest_cursesfail on themacos-26-intelrunner.Probe whether the format is deterministic and only run the dump-file comparisons when it is. On platforms where it is not, the test still checks that the dump is non-empty and that
scr_restore(),scr_init()andscr_set()succeed.